-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating test vectors for Action Groups #24
Conversation
5178665
to
d4d99b1
Compare
d4d99b1
to
ae2d95e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good overall. Added some comments, mostly cosmetics for this PR and the zip.
…94) This PR makes the changes to the test vectors that have been made in QED-it/zcash-test-vectors#24, to reflect the updated transaction format that uses Action Groups, and the updated computations for the SIGHASH and the Authorizing Data Commitment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge it
This PR makes the changes corresponding to the updates in the V6 transaction format and digest computation, especially for the update to include Action Groups.